netdev - Re: [PATCH net] inet_diag: return classid for all socket types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200308.215821.1029255577399058866.davem@davemloft.net>
Date:   Sun, 08 Mar 2020 21:58:21 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     zeil@...dex-team.ru
Cc:     netdev@...r.kernel.org, khlebnikov@...dex-team.ru
Subject: Re: [PATCH net] inet_diag: return classid for all socket types

From: Dmitry Yakunin <zeil@...dex-team.ru>
Date: Thu, 5 Mar 2020 15:33:12 +0300

> In commit 1ec17dbd90f8 ("inet_diag: fix reporting cgroup classid and
> fallback to priority") croup classid reporting was fixed. But this works
> only for TCP sockets because for other socket types icsk parameter can
> be NULL and classid code path is skipped. This change moves classid
> handling to inet_diag_msg_attrs_fill() function.
> 
> Also inet_diag_msg_attrs_size() helper was added and addends in
> nlmsg_new() were reordered to save order from inet_sk_diag_fill().
> 
> Fixes: 1ec17dbd90f8 ("inet_diag: fix reporting cgroup classid and fallback to priority")
> Signed-off-by: Dmitry Yakunin <zeil@...dex-team.ru>
> Reviewed-by: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>

Applied and queued up for -stable, thanks.