netdev - Re: [PATCH net-next v4 1/6] cxgb4/chcr : Register to tls add and del callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200309160526.26845f55@kicinski-fedora-PC1C0HJN>
Date:   Mon, 9 Mar 2020 16:05:26 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Rohit Maheshwari <rohitm@...lsio.com>
Cc:     borisp@...lanox.com, netdev@...r.kernel.org, davem@...emloft.net,
        herbert@...dor.apana.org.au, secdev@...lsio.com, varun@...lsio.com
Subject: Re: [PATCH net-next v4 1/6] cxgb4/chcr : Register to tls add and
 del callback

On Sat,  7 Mar 2020 20:06:03 +0530 Rohit Maheshwari wrote:
> A new macro is defined to enable ktls tx offload support on Chelsio
> T6 adapter. And if this macro is enabled, cxgb4 will send mailbox to
> enable or disable ktls settings on HW.
> In chcr, enabled tx offload flag in netdev and registered tls_dev_add
> and tls_dev_del.
> 
> v1->v2:
> - mark tcb state to close in tls_dev_del.
> - u_ctx is now picked from adapter structure.
> - clear atid in case of failure.
> - corrected ULP_CRYPTO_KTLS_INLINE value.
> 
> v2->v3:
> - add empty line after variable declaration.
> - local variable declaration in reverse christmas tree ordering.
> 
> Signed-off-by: Rohit Maheshwari <rohitm@...lsio.com>

What ciphers do you support? You never check cipher type.