lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 9 Mar 2020 16:18:24 -0700
From:   Roman Gushchin <>
To:     Andrii Nakryiko <>
CC:     <>, <>, <>,
        <>, <>,
Subject: Re: [PATCH bpf] bpf: fix cgroup ref leak in cgroup_bpf_inherit on

On Mon, Mar 09, 2020 at 03:40:17PM -0700, Andrii Nakryiko wrote:
> There is no compensating cgroup_bpf_put() for each ancestor cgroup in
> cgroup_bpf_inherit(). If compute_effective_progs returns error, those cgroups
> won't be freed ever. Fix it by putting them in cleanup code path.
> Fixes: e10360f815ca ("bpf: cgroup: prevent out-of-order release of cgroup bpf")
> Signed-off-by: Andrii Nakryiko <>

Acked-by: Roman Gushchin <>

Thanks, Andrii!

Powered by blists - more mailing lists