netdev - Re: [PATCH 00/10] qlge.h cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200309061818.GB24692@f3>
Date:   Mon, 9 Mar 2020 15:18:18 +0900
From:   Benjamin Poirier <benjamin.poirier@...il.com>
To:     Jarrett Knauer <jrtknauer@...il.com>
Cc:     manishc@...vell.com, GR-Linux-NIC-Dev@...vell.com,
        gregkh@...uxfoundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH 00/10] qlge.h cleanup - first pass

On 2020-03-07 23:23 -0700, Jarrett Knauer wrote:
> This patchset cleans up some warnings and checks issued by checkpatch.pl
> for staging: qlge: qlge.h as an effort to eventually bring the qlge TODO
> count to zero.
> 
> There are still many CHECKs and WARNINGs for qlge.h, of which some are
> false-positives or odd instances which I plan on returning to after
> getting some more experience with the driver.
> 
> Jarrett Knauer (10):
>   staging: qlge: removed leading spaces identified by checkpatch.pl
>   staging: qlge: checkpatch.pl CHECK - removed unecessary blank line
>   staging: qlge: checkpatch.pl WARNING - removed spaces before tabs
>   staging: qlge: checkpatch.pl CHECK - added spaces around /
>   staging: qlge: checkpatch.pl WARNING - removed spaces before tabs
>   staging: qlge: checkpatch.pl CHECK - added spaces around %
>   staging: qlge: checkpatch.pl CHECK - removed blank line following
>     brace
>   staging: qlge: checkpatch.pl CHECK - removed blank line after brace
>   staging: qlge: checkpatch.pl WARNING - removed function pointer space
>   staging: qlge: checkpatch.pl WARNING - missing blank line

It seems like this cover letter made it to the netdev mailing list but
not the actual patches. Please double check and resend.

> 
>  drivers/staging/qlge/qlge.h | 42 ++++++++++++++++++-------------------
>  1 file changed, 20 insertions(+), 22 deletions(-)

Also, as discussed earlier and looking at the diffstat now, a single
patch would be fine I think.