netdev - Re: [PATCH net-next 0/10] net: dsa: improve serdes integration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200309094828.GJ25745@shell.armlinux.org.uk>
Date:   Mon, 9 Mar 2020 09:48:28 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     David Miller <davem@...emloft.net>
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        kuba@...nel.org, netdev@...r.kernel.org, vivien.didelot@...il.com
Subject: Re: [PATCH net-next 0/10] net: dsa: improve serdes integration

On Sun, Mar 08, 2020 at 10:04:47PM -0700, David Miller wrote:
> From: Russell King - ARM Linux admin <linux@...linux.org.uk>
> Date: Thu, 5 Mar 2020 12:41:39 +0000
> 
> > Andrew Lunn mentioned that the Serdes PCS found in Marvell DSA switches
> > does not automatically update the switch MACs with the link parameters.
> > Currently, the DSA code implements a work-around for this.
> > 
> > This series improves the Serdes integration, making use of the recent
> > phylink changes to support split MAC/PCS setups.  One noticable
> > improvement for userspace is that ethtool can now report the link
> > partner's advertisement.
> 
> It looks like Andrew's regression has to be sorted out, so I'm deferring
> this.

Yep - it comes from the poor integration of phylink into DSA for CPU
and inter-DSA ports which is already causing regressions in today's
kernels. That needs resolving somehow before this patch series can
be merged, but it isn't something that can be fixed from the phylink
side of things.

I'll postpone these patches until that issue is resolved.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up