lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Mar 2020 09:53:28 +0200 From: Paul Blakey <paulb@...lanox.com> To: Edward Cree <ecree@...arflare.com>, Saeed Mahameed <saeedm@...lanox.com>, Oz Shlomo <ozsh@...lanox.com>, Jakub Kicinski <jakub.kicinski@...ronome.com>, Vlad Buslov <vladbu@...lanox.com>, David Miller <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Jiri Pirko <jiri@...lanox.com>, Roi Dayan <roid@...lanox.com> Subject: Re: [PATCH net-next ct-offload v2 05/13] net/sched: act_ct: Enable hardware offload of flow table entires On 3/9/2020 11:25 PM, Edward Cree wrote: > On 08/03/2020 14:10, Paul Blakey wrote: >> Pass the zone's flow table instance on the flow action to the drivers. >> Thus, allowing drivers to register FT add/del/stats callbacks. >> >> Finally, enable hardware offload on the flow table instance. >> >> Signed-off-by: Paul Blakey <paulb@...lanox.com> >> Reviewed-by: Jiri Pirko <jiri@...lanox.com> >> --- >> <snip> >> diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c >> index 84d5abf..d52185d 100644 >> --- a/net/sched/act_ct.c >> +++ b/net/sched/act_ct.c >> @@ -292,6 +292,7 @@ static int tcf_ct_flow_table_get(struct tcf_ct_params *params) >> goto err_insert; >> >> ct_ft->nf_ft.type = &flowtable_ct; >> + ct_ft->nf_ft.flags |= NF_FLOWTABLE_HW_OFFLOAD; >> err = nf_flow_table_init(&ct_ft->nf_ft); >> if (err) >> goto err_init; >> @@ -299,6 +300,7 @@ static int tcf_ct_flow_table_get(struct tcf_ct_params *params) >> __module_get(THIS_MODULE); >> take_ref: >> params->ct_ft = ct_ft; >> + params->nf_ft = &ct_ft->nf_ft; >> ct_ft->ref++; >> spin_unlock_bh(&zones_lock); > This doesn't seem to apply to net-next (34a568a244be); the label after > the __module_get() is 'out_unlock', not 'take_ref'. Is there a missing > prerequisite patch? Or am I just failing to drive 'git am' correctly? It's was rebased only on top of saeeds ct-offload, will rebase it on net next as well. > > -ed
Powered by blists - more mailing lists