netdev - RE: [PATCH net-next 01/15] net: ena: reject unsupported coalescing params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba82e88dd3ac45a5a8e4527531d385c0@EX13D22EUA004.ant.amazon.com>
Date:   Tue, 10 Mar 2020 14:16:03 +0000
From:   "Kiyanovski, Arthur" <akiyano@...zon.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Belgazal, Netanel" <netanel@...zon.com>,
        "Tzalik, Guy" <gtzalik@...zon.com>,
        "irusskikh@...vell.com" <irusskikh@...vell.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "bcm-kernel-feedback-list@...adcom.com" 
        <bcm-kernel-feedback-list@...adcom.com>,
        "rmody@...vell.com" <rmody@...vell.com>,
        "GR-Linux-NIC-Dev@...vell.com" <GR-Linux-NIC-Dev@...vell.com>,
        "aelior@...vell.com" <aelior@...vell.com>,
        "skalluru@...vell.com" <skalluru@...vell.com>,
        "GR-everest-linux-l2@...vell.com" <GR-everest-linux-l2@...vell.com>,
        "opendmb@...il.com" <opendmb@...il.com>,
        "siva.kallam@...adcom.com" <siva.kallam@...adcom.com>,
        "prashant@...adcom.com" <prashant@...adcom.com>,
        "mchan@...adcom.com" <mchan@...adcom.com>,
        "dchickles@...vell.com" <dchickles@...vell.com>,
        "sburla@...vell.com" <sburla@...vell.com>,
        "fmanlunas@...vell.com" <fmanlunas@...vell.com>,
        "tariqt@...lanox.com" <tariqt@...lanox.com>,
        "vishal@...lsio.com" <vishal@...lsio.com>,
        "leedom@...lsio.com" <leedom@...lsio.com>,
        "ulli.kroll@...glemail.com" <ulli.kroll@...glemail.com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>
Subject: RE: [PATCH net-next 01/15] net: ena: reject unsupported coalescing params

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Tuesday, March 10, 2020 4:15 AM
> To: davem@...emloft.net
> Cc: netdev@...r.kernel.org; Kiyanovski, Arthur <akiyano@...zon.com>;
> Belgazal, Netanel <netanel@...zon.com>; Tzalik, Guy <gtzalik@...zon.com>;
> irusskikh@...vell.com; f.fainelli@...il.com; bcm-kernel-feedback-
> list@...adcom.com; rmody@...vell.com; GR-Linux-NIC-Dev@...vell.com;
> aelior@...vell.com; skalluru@...vell.com; GR-everest-linux-l2@...vell.com;
> opendmb@...il.com; siva.kallam@...adcom.com; prashant@...adcom.com;
> mchan@...adcom.com; dchickles@...vell.com; sburla@...vell.com;
> fmanlunas@...vell.com; tariqt@...lanox.com; vishal@...lsio.com;
> leedom@...lsio.com; ulli.kroll@...glemail.com; linus.walleij@...aro.org;
> Jakub Kicinski <kuba@...nel.org>
> Subject: [EXTERNAL][PATCH net-next 01/15] net: ena: reject unsupported
> coalescing params
> 
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
> 
> 
> 
> Set ethtool_ops->supported_coalesce_params to let the core reject
> unsupported coalescing parameters.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  drivers/net/ethernet/amazon/ena/ena_ethtool.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/amazon/ena/ena_ethtool.c
> b/drivers/net/ethernet/amazon/ena/ena_ethtool.c
> index 868265a2ec00..552d4cbf6dbd 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_ethtool.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_ethtool.c
> @@ -826,6 +826,8 @@ static int ena_set_tunable(struct net_device *netdev,  }
> 
>  static const struct ethtool_ops ena_ethtool_ops = {
> +       .supported_coalesce_params = ETHTOOL_COALESCE_USECS |
> +                                    ETHTOOL_COALESCE_USE_ADAPTIVE_RX,
>         .get_link_ksettings     = ena_get_link_ksettings,
>         .get_drvinfo            = ena_get_drvinfo,
>         .get_msglevel           = ena_get_msglevel,
> --
> 2.24.1


Acked-by: Sameeh Jubran <sameehj@...zon.com>