lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 10 Mar 2020 08:53:56 -0700
From:   Eric Dumazet <>
To:     Shakeel Butt <>,
        Eric Dumazet <>,
        Roman Gushchin <>
Cc:     Johannes Weiner <>,
        Michal Hocko <>,
        Greg Thelen <>,
        Andrew Morton <>,
        "David S . Miller" <>,
        Alexey Kuznetsov <>,
        Hideaki YOSHIFUJI <>,,,,
Subject: Re: [PATCH v4 2/2] net: memcg: late association of sock to memcg

On 3/9/20 10:16 PM, Shakeel Butt wrote:
> If a TCP socket is allocated in IRQ context or cloned from unassociated
> (i.e. not associated to a memcg) in IRQ context then it will remain
> unassociated for its whole life. Almost half of the TCPs created on the
> system are created in IRQ context, so, memory used by such sockets will
> not be accounted by the memcg.
> This issue is more widespread in cgroup v1 where network memory
> accounting is opt-in but it can happen in cgroup v2 if the source socket
> for the cloning was created in root memcg.
> To fix the issue, just do the association of the sockets at the accept()
> time in the process context and then force charge the memory buffer
> already used and reserved by the socket.
> Signed-off-by: Shakeel Butt <>

Reviewed-by: Eric Dumazet <>

Thanks !

Powered by blists - more mailing lists