netdev - Re: [PATCH rdma-rc] IB/mlx5: Replace tunnel mpls capability bits for tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200310181001.GA7735@ziepe.ca>
Date:   Tue, 10 Mar 2020 15:10:01 -0300
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Doug Ledford <dledford@...hat.com>,
        Alex Vesker <valex@...lanox.com>,
        Ariel Levkovich <lariel@...lanox.com>,
        linux-rdma@...r.kernel.org, Mark Bloch <markb@...lanox.com>,
        netdev@...r.kernel.org, Saeed Mahameed <saeedm@...lanox.com>
Subject: Re: [PATCH rdma-rc] IB/mlx5: Replace tunnel mpls capability bits for
 tunnel_offloads

On Thu, Mar 05, 2020 at 02:38:41PM +0200, Leon Romanovsky wrote:
> From: Alex Vesker <valex@...lanox.com>
> 
> Until now flex parser was used in ib_query_device to indicate
> tunnel_offloads_caps support for mpls_over_gre/mpls_over_udp.
> These inaccurate capability bits will not work on newer devices.
> 
> This should not brake backward compatibility since tunnel_stateless
> caps and flex_parser_protocols caps were added together.
> 
> Cc: <stable@...r.kernel.org> # 4.17
> Fixes: e818e255a58d ("IB/mlx5: Expose MPLS related tunneling offloads")
> Signed-off-by: Alex Vesker <valex@...lanox.com>
> Reviewed-by: Ariel Levkovich <lariel@...lanox.com>
> Signed-off-by: Leon Romanovsky <leonro@...lanox.com>
> ---
>  drivers/infiniband/hw/mlx5/main.c | 6 ++----
>  include/linux/mlx5/mlx5_ifc.h     | 6 +++++-
>  2 files changed, 7 insertions(+), 5 deletions(-)

Compatability with future devices is not really a -rc thing

Applied to for-next, thanks

Jason