netdev - Re: [PATCH iproute2-next] Revert "tc: pie: change maximum integer value of tc_pie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1122d071-7728-94fc-a32a-f2cf31102312@gmail.com>
Date:   Tue, 10 Mar 2020 12:30:42 -0600
From:   David Ahern <dsahern@...il.com>
To:     Leslie Monis <lesliemonis@...il.com>,
        Linux NetDev <netdev@...r.kernel.org>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        "Mohit P . Tahiliani" <tahiliani@...k.edu.in>,
        Gautam Ramakrishnan <gautamramk@...il.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH iproute2-next] Revert "tc: pie: change maximum integer
 value of tc_pie_xstats->prob"

On 3/10/20 12:15 PM, Leslie Monis wrote:
> This reverts commit 92cfe3260e9110c3d33627847b6eaa153664c79c.
> 
> Kernel commit 3f95f55eb55d ("net: sched: pie: change tc_pie_xstats->prob")
> removes the need to change the maximum integer value of
> tc_pie_stats->prob here.
> 
> Suggested-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Leslie Monis <lesliemonis@...il.com>
> ---
>  tc/q_pie.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tc/q_pie.c b/tc/q_pie.c
> index e6939652..709a78b4 100644
> --- a/tc/q_pie.c
> +++ b/tc/q_pie.c
> @@ -223,9 +223,9 @@ static int pie_print_xstats(struct qdisc_util *qu, FILE *f,
>  
>  	st = RTA_DATA(xstats);
>  
> -	/* prob is returned as a fracion of (2^56 - 1) */
> +	/* prob is returned as a fracion of maximum integer value */
>  	print_float(PRINT_ANY, "prob", "  prob %lg",
> -		    (double)st->prob / (double)(UINT64_MAX >> 8));
> +		    (double)st->prob / (double)UINT64_MAX);
>  	print_uint(PRINT_JSON, "delay", NULL, st->delay);
>  	print_string(PRINT_FP, NULL, " delay %s", sprint_time(st->delay, b1));
>  
> 

applied to iproute2-next. Thanks