lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 10 Mar 2020 18:20:20 -0400
From:   Jes Sorensen <>
To:     "Gustavo A. R. Silva" <>,
        Kalle Valo <>
Cc:     Joe Perches <>, Daniel Drake <>,
        Ulrich Kunitz <>,
        "David S. Miller" <>,,,
Subject: Re: [PATCH][next] zd1211rw/zd_usb.h: Replace zero-length array with
 flexible-array member

On 3/10/20 6:13 PM, Gustavo A. R. Silva wrote:
> On 3/10/20 5:07 PM, Jes Sorensen wrote:
>> As I stated in my previous answer, this seems more code churn than an
>> actual fix. If this is a real problem, shouldn't the work be put into
>> fixing the compiler to handle foo[0] instead? It seems that is where the
>> real value would be.
> Yeah. But, unfortunately, I'm not a compiler guy, so I'm not able to fix the
> compiler as you suggest. And I honestly don't see what is so annoying/disturbing
> about applying a patch that removes the 0 from foo[0] when it brings benefit
> to the whole codebase.

My point is that it adds what seems like unnecessary churn, which is not
a benefit, and it doesn't improve the generated code.

Best regards,

Powered by blists - more mailing lists