netdev - Re: [PATCH] net: dsa: mt7530: fix macro MIRROR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200310.161439.2227645091198630571.davem@davemloft.net>
Date:   Tue, 10 Mar 2020 16:14:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dqfext@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: dsa: mt7530: fix macro MIRROR_PORT

From: DENG Qingfang <dqfext@...il.com>
Date: Wed, 11 Mar 2020 02:20:50 +0800

> The inner pair of parentheses should be around the variable x
> Fixes: 37feab6076aa ("net: dsa: mt7530: add support for port mirroring")
> 
> Signed-off-by: DENG Qingfang <dqfext@...il.com>

Two things:

1) In the Subject line always indicate the target tree for your changes.
   This case would be net-next since that is the only tree where the
   Fixes: tag commit exists, thus "Subject: [PATCH net-next] ..."

2) Always group the various tags together into a contiguous series of
   lines of text, starting the the Fixes tag.  Make sure there is an
   empty line between the commit message description text, and the tags.

I fixes it up for you this time, but next time I will not and push back
for you to fix it up yourself.

Applied to net-next, thank you.