netdev - Re: [PATCH net] sfc: detach from cb_page in efx_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200309.174452.1216342842615589776.davem@davemloft.net>
Date:   Mon, 09 Mar 2020 17:44:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ecree@...arflare.com
Cc:     linux-net-drivers@...arflare.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] sfc: detach from cb_page in efx_copy_channel()

From: Edward Cree <ecree@...arflare.com>
Date: Mon, 9 Mar 2020 18:16:24 +0000

> It's a resource, not a parameter, so we can't copy it into the new
>  channel's TX queues, otherwise aliasing will lead to resource-
>  management bugs if the channel is subsequently torn down without
>  being initialised.
> 
> Before the Fixes:-tagged commit there was a similar bug with
>  tsoh_page, but I'm not sure it's worth doing another fix for such
>  old kernels.
> 
> Fixes: e9117e5099ea ("sfc: Firmware-Assisted TSO version 2")
> Suggested-by: Derek Shute <Derek.Shute@...atus.com>
> Signed-off-by: Edward Cree <ecree@...arflare.com>
> ---
> The Fixes: is in v4.10, so this will want to go to stable for
>  4.14 and later.  Note that the recent refactoring has moved the
>  code; in the stable trees efx_copy_channel() will be in efx.c
>  rather than efx_channels.c.

Ok, applied and queued up for -stable, thanks.