lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon,  9 Mar 2020 19:15:05 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     davem@...emloft.net
Cc:     netdev@...r.kernel.org, akiyano@...zon.com, netanel@...zon.com,
        gtzalik@...zon.com, irusskikh@...vell.com, f.fainelli@...il.com,
        bcm-kernel-feedback-list@...adcom.com, rmody@...vell.com,
        GR-Linux-NIC-Dev@...vell.com, aelior@...vell.com,
        skalluru@...vell.com, GR-everest-linux-l2@...vell.com,
        opendmb@...il.com, siva.kallam@...adcom.com, prashant@...adcom.com,
        mchan@...adcom.com, dchickles@...vell.com, sburla@...vell.com,
        fmanlunas@...vell.com, tariqt@...lanox.com, vishal@...lsio.com,
        leedom@...lsio.com, ulli.kroll@...glemail.com,
        linus.walleij@...aro.org, Jakub Kicinski <kuba@...nel.org>
Subject: [PATCH net-next 08/15] net: bna: reject unsupported coalescing params

Set ethtool_ops->supported_coalesce_params to let
the core reject unsupported coalescing parameters.

This driver did not previously reject unsupported parameters.

Signed-off-by: Jakub Kicinski <kuba@...nel.org>
---
 drivers/net/ethernet/brocade/bna/bnad_ethtool.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/brocade/bna/bnad_ethtool.c b/drivers/net/ethernet/brocade/bna/bnad_ethtool.c
index 505e9c6d74a6..588c4804d10a 100644
--- a/drivers/net/ethernet/brocade/bna/bnad_ethtool.c
+++ b/drivers/net/ethernet/brocade/bna/bnad_ethtool.c
@@ -1115,6 +1115,9 @@ bnad_flash_device(struct net_device *netdev, struct ethtool_flash *eflash)
 }
 
 static const struct ethtool_ops bnad_ethtool_ops = {
+	.supported_coalesce_params = ETHTOOL_COALESCE_USECS |
+				     ETHTOOL_COALESCE_TX_MAX_FRAMES |
+				     ETHTOOL_COALESCE_USE_ADAPTIVE_RX,
 	.get_drvinfo = bnad_get_drvinfo,
 	.get_wol = bnad_get_wol,
 	.get_link = ethtool_op_get_link,
-- 
2.24.1

Powered by blists - more mailing lists