netdev - Re: [PATCH bpf-next] bpf: initialize storage pointers to NULL to prevent freeing garbage pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 9 Mar 2020 19:58:24 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Andrii Nakryiko <andriin@...com>
Cc:     bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next] bpf: initialize storage pointers to NULL to
 prevent freeing garbage pointer

On Mon, Mar 9, 2020 at 3:28 PM Andrii Nakryiko <andriin@...com> wrote:
>
> Local storage array isn't initialized, so if cgroup storage allocation fails
> for BPF_CGROUP_STORAGE_SHARED, error handling code will attempt to free
> uninitialized pointer for BPF_CGROUP_STORAGE_PERCPI storage type. Avoid this
> by always initializing storage pointers to NULLs.
>
> Fixes: 8bad74f9840f ("bpf: extend cgroup bpf core to allow multiple cgroup storage types")
> Signed-off-by: Andrii Nakryiko <andriin@...com>

Applied to bpf tree and fixed typo in commit log.