netdev - Re: [PATCH net] ipvlan: don't deref eth hdr before checking it's set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200309.180032.2250303823050962358.davem@davemloft.net>
Date:   Mon, 09 Mar 2020 18:00:32 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     maheshb@...gle.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, mahesh@...dewar.net
Subject: Re: [PATCH net] ipvlan: don't deref eth hdr before checking it's
 set

From: Mahesh Bandewar <maheshb@...gle.com>
Date: Mon,  9 Mar 2020 15:56:56 -0700

> IPvlan in L3 mode discards outbound multicast packets but performs
> the check before ensuring the ether-header is set or not. This is
> an error that Eric found through code browsing.
> 
> Fixes: 2ad7bf363841 (“ipvlan: Initial check-in of the IPVLAN driver.”)
> Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>
> Reported-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable.