netdev - Re: [oss-drivers] [PATCH 4/7] nfp: Use scnprintf() for avoiding potential buffer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200311110111.GA304@netronome.com>
Date:   Wed, 11 Mar 2020 12:01:12 +0100
From:   Simon Horman <simon.horman@...ronome.com>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, oss-drivers@...ronome.com
Subject: Re: [oss-drivers] [PATCH 4/7] nfp: Use scnprintf() for avoiding
 potential buffer overflow

On Wed, Mar 11, 2020 at 09:37:42AM +0100, Takashi Iwai wrote:
> Since snprintf() returns the would-be-output size instead of the
> actual output size, the succeeding calls may go beyond the given
> buffer limit.  Fix it by replacing with scnprintf().
> 
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: oss-drivers@...ronome.com
> Signed-off-by: Takashi Iwai <tiwai@...e.de>

Reviewed-by: Simon Horman <simon.horman@...ronome.com>