netdev - Re: [PATCH bpf-next v5 12/12] selftests/bpf: Tests for SOCKMAP holding listening sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Mar 2020 14:02:47 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Jakub Sitnicki <jakub@...udflare.com>
Cc:     bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        kernel-team@...udflare.com
Subject: Re: [PATCH bpf-next v5 12/12] selftests/bpf: Tests for SOCKMAP
 holding listening sockets

On Wed, Mar 11, 2020 at 12:49 PM Jakub Sitnicki <jakub@...udflare.com> wrote:
>
> On Wed, Mar 11, 2020 at 07:48 PM CET, Andrii Nakryiko wrote:
> > On Mon, Jan 27, 2020 at 4:58 AM Jakub Sitnicki <jakub@...udflare.com> wrote:
> >>
> >> Now that SOCKMAP can store listening sockets, user-space and BPF API is
> >> open to a new set of potential pitfalls. Exercise the map operations (with
> >> extra attention to code paths susceptible to races between map ops and
> >> socket cloning), and BPF helpers that work with SOCKMAP to gain confidence
> >> that all works as expected.
> >>
> >> Signed-off-by: Jakub Sitnicki <jakub@...udflare.com>
> >> ---
> >>  .../selftests/bpf/prog_tests/sockmap_listen.c | 1455 +++++++++++++++++
> >>  .../selftests/bpf/progs/test_sockmap_listen.c |   77 +
> >>  2 files changed, 1532 insertions(+)
> >>  create mode 100644 tools/testing/selftests/bpf/prog_tests/sockmap_listen.c
> >>  create mode 100644 tools/testing/selftests/bpf/progs/test_sockmap_listen.c
> >>
> >
> > Hey Jakub!
> >
> > I'm frequently getting spurious failures for sockmap_listen selftest.
> > We also see that in libbpf's Github CI testing as well. Do you mind
> > taking a look? Usually it's the following kinds of error:
> >
> > ./test_progs:connect_accept_thread:733: accept: Resource temporarily unavailable
> > connect_accept_thread:FAIL:733
>
> Hey Andrii,
>
> Sorry about that. Will investigate why this is happening.
>
> Can't say I've seen those. Any additional details about the test
> enviroment would be helpful. Like the kernel build config and qemu
> params (e.g. 1 vCPU vs more).

It happens quite regularly for me, once every few runs locally. You
can take a kernel config we use for Travis CI at [0].

  [0] https://github.com/libbpf/libbpf/blob/master/travis-ci/vmtest/configs/latest.config

>
> I've taken a quick look at Github CI [0] to see if I can find a sample
> failure report and fish out the kernel config & VM setup from the test
> job spec, but didn't succeed. Will dig more later, unless you have a
> link handy?

We are blacklisting sockmap_listen test right now, so you won't find
anything recent on Travis.

>
> Thanks,
> -jkbs
>
> [0] https://travis-ci.org/github/libbpf/libbpf