lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Mar 2020 12:18:54 +0900 From: Takashi Sakamoto <o-takashi@...amocchi.jp> To: Jules Irenge <jbi.octave@...il.com> Cc: boqun.feng@...il.com, linux-kernel@...r.kernel.org, bpf@...r.kernel.org, netdev@...r.kernel.org, Clemens Ladisch <clemens@...isch.de>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Alexios Zavras <alexios.zavras@...el.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Thomas Gleixner <tglx@...utronix.de>, Allison Randal <allison@...utok.net>, "moderated list:FIREWIRE AUDIO DRIVERS and IEC 61883-1/6 PACKET..." <alsa-devel@...a-project.org> Subject: Re: [PATCH 8/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_locked() Hi, On Wed, Mar 11, 2020 at 01:09:08AM +0000, Jules Irenge wrote: > Sparse reports a warning at tscm_hwdep_read_locked() > > warning: context imbalance in tscm_hwdep_read_locked() - unexpected unlock > > The root cause is the missing annotation at tscm_hwdep_read_locked() > Add the missing __releases(&tscm->lock) annotation > > Signed-off-by: Jules Irenge <jbi.octave@...il.com> > --- > sound/firewire/tascam/tascam-hwdep.c | 1 + > 1 file changed, 1 insertion(+) Thanks for your care of the warning. Although I have found it, I had no idea to suppress it. Acked-by: Takashi Sakamoto <o-takashi@...amocchi.jp> > diff --git a/sound/firewire/tascam/tascam-hwdep.c b/sound/firewire/tascam/tascam-hwdep.c > index 9801e33e7f2a..6f38335fe10b 100644 > --- a/sound/firewire/tascam/tascam-hwdep.c > +++ b/sound/firewire/tascam/tascam-hwdep.c > @@ -17,6 +17,7 @@ > > static long tscm_hwdep_read_locked(struct snd_tscm *tscm, char __user *buf, > long count, loff_t *offset) > + __releases(&tscm->lock) > { > struct snd_firewire_event_lock_status event = { > .type = SNDRV_FIREWIRE_EVENT_LOCK_STATUS, > -- > 2.24.1 >
Powered by blists - more mailing lists