netdev - Re: [PATCH net-next 01/15] net: ena: reject unsupported coalescing params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200311065628.GD4215@unreal>
Date:   Wed, 11 Mar 2020 08:56:28 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     "Kiyanovski, Arthur" <akiyano@...zon.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Belgazal, Netanel" <netanel@...zon.com>,
        "Tzalik, Guy" <gtzalik@...zon.com>,
        "irusskikh@...vell.com" <irusskikh@...vell.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "bcm-kernel-feedback-list@...adcom.com" 
        <bcm-kernel-feedback-list@...adcom.com>,
        "rmody@...vell.com" <rmody@...vell.com>,
        "GR-Linux-NIC-Dev@...vell.com" <GR-Linux-NIC-Dev@...vell.com>,
        "aelior@...vell.com" <aelior@...vell.com>,
        "skalluru@...vell.com" <skalluru@...vell.com>,
        "GR-everest-linux-l2@...vell.com" <GR-everest-linux-l2@...vell.com>,
        "opendmb@...il.com" <opendmb@...il.com>,
        "siva.kallam@...adcom.com" <siva.kallam@...adcom.com>,
        "prashant@...adcom.com" <prashant@...adcom.com>,
        "mchan@...adcom.com" <mchan@...adcom.com>,
        "dchickles@...vell.com" <dchickles@...vell.com>,
        "sburla@...vell.com" <sburla@...vell.com>,
        "fmanlunas@...vell.com" <fmanlunas@...vell.com>,
        "tariqt@...lanox.com" <tariqt@...lanox.com>,
        "vishal@...lsio.com" <vishal@...lsio.com>,
        "leedom@...lsio.com" <leedom@...lsio.com>,
        "ulli.kroll@...glemail.com" <ulli.kroll@...glemail.com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>
Subject: Re: [PATCH net-next 01/15] net: ena: reject unsupported coalescing
 params

On Tue, Mar 10, 2020 at 08:55:33PM +0000, Kiyanovski, Arthur wrote:
>
>
> > -----Original Message-----
> > From: Leon Romanovsky <leon@...nel.org>
> > Sent: Tuesday, March 10, 2020 8:32 PM
> > To: Kiyanovski, Arthur <akiyano@...zon.com>
> > Cc: Jakub Kicinski <kuba@...nel.org>; davem@...emloft.net;
> > netdev@...r.kernel.org; Belgazal, Netanel <netanel@...zon.com>; Tzalik,
> > Guy <gtzalik@...zon.com>; irusskikh@...vell.com; f.fainelli@...il.com;
> > bcm-kernel-feedback-list@...adcom.com; rmody@...vell.com; GR-Linux-NIC-
> > Dev@...vell.com; aelior@...vell.com; skalluru@...vell.com; GR-everest-
> > linux-l2@...vell.com; opendmb@...il.com; siva.kallam@...adcom.com;
> > prashant@...adcom.com; mchan@...adcom.com; dchickles@...vell.com;
> > sburla@...vell.com; fmanlunas@...vell.com; tariqt@...lanox.com;
> > vishal@...lsio.com; leedom@...lsio.com; ulli.kroll@...glemail.com;
> > linus.walleij@...aro.org
> > Subject: RE: [EXTERNAL][PATCH net-next 01/15] net: ena: reject unsupported
> > coalescing params
> >
> > CAUTION: This email originated from outside of the organization. Do not click
> > links or open attachments unless you can confirm the sender and know the
> > content is safe.
> >
> >
> >
> > On Tue, Mar 10, 2020 at 02:16:03PM +0000, Kiyanovski, Arthur wrote:
> > > > -----Original Message-----
> > > > From: Jakub Kicinski <kuba@...nel.org>
> > > > Sent: Tuesday, March 10, 2020 4:15 AM
> > > > To: davem@...emloft.net
> > > > Cc: netdev@...r.kernel.org; Kiyanovski, Arthur <akiyano@...zon.com>;
> > > > Belgazal, Netanel <netanel@...zon.com>; Tzalik, Guy
> > > > <gtzalik@...zon.com>; irusskikh@...vell.com; f.fainelli@...il.com;
> > > > bcm-kernel-feedback- list@...adcom.com; rmody@...vell.com;
> > > > GR-Linux-NIC-Dev@...vell.com; aelior@...vell.com;
> > > > skalluru@...vell.com; GR-everest-linux-l2@...vell.com;
> > > > opendmb@...il.com; siva.kallam@...adcom.com;
> > prashant@...adcom.com;
> > > > mchan@...adcom.com; dchickles@...vell.com; sburla@...vell.com;
> > > > fmanlunas@...vell.com; tariqt@...lanox.com; vishal@...lsio.com;
> > > > leedom@...lsio.com; ulli.kroll@...glemail.com;
> > > > linus.walleij@...aro.org; Jakub Kicinski <kuba@...nel.org>
> > > > Subject: [EXTERNAL][PATCH net-next 01/15] net: ena: reject
> > > > unsupported coalescing params
> > > >
> > > > CAUTION: This email originated from outside of the organization. Do
> > > > not click links or open attachments unless you can confirm the
> > > > sender and know the content is safe.
> > > >
> > > >
> > > >
> > > > Set ethtool_ops->supported_coalesce_params to let the core reject
> > > > unsupported coalescing parameters.
> > > >
> > > > Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> > > > ---
> > > >  drivers/net/ethernet/amazon/ena/ena_ethtool.c | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/drivers/net/ethernet/amazon/ena/ena_ethtool.c
> > > > b/drivers/net/ethernet/amazon/ena/ena_ethtool.c
> > > > index 868265a2ec00..552d4cbf6dbd 100644
> > > > --- a/drivers/net/ethernet/amazon/ena/ena_ethtool.c
> > > > +++ b/drivers/net/ethernet/amazon/ena/ena_ethtool.c
> > > > @@ -826,6 +826,8 @@ static int ena_set_tunable(struct net_device
> > > > *netdev,  }
> > > >
> > > >  static const struct ethtool_ops ena_ethtool_ops = {
> > > > +       .supported_coalesce_params = ETHTOOL_COALESCE_USECS |
> > > > +
> > > > + ETHTOOL_COALESCE_USE_ADAPTIVE_RX,
> > > >         .get_link_ksettings     = ena_get_link_ksettings,
> > > >         .get_drvinfo            = ena_get_drvinfo,
> > > >         .get_msglevel           = ena_get_msglevel,
> > > > --
> > > > 2.24.1
> > >
> > >
> > > Acked-by: Sameeh Jubran <sameehj@...zon.com>
> >
> > FROM author of this reply and Acked-by doesn't look the same.
> > Which one is correct?
> >
> > Thanks
>
> Sameeh did the check, I sent the email.
> So the correct one is the one written in the email:
> Acked-by: Sameeh Jubran <sameehj@...zon.com>
>
> Sorry for the confusion.

It is important that the one who adds "-by" writes the email and uses
same name, because get-lore-mbox.py (the new tool that used by many
maintainers to grab patches) performs strict check between From and
tags to be on the safe side.

Thanks