lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Mar 2020 08:19:55 +0100 From: Jiri Pirko <jiri@...nulli.us> To: Jakub Kicinski <kuba@...nel.org> Cc: netdev@...r.kernel.org, davem@...emloft.net, saeedm@...lanox.com, pablo@...filter.org, ecree@...arflare.com Subject: Re: [patch net-next 0/3] flow_offload: follow-ups to HW stats type patchset Tue, Mar 10, 2020 at 08:05:19PM CET, kuba@...nel.org wrote: >On Tue, 10 Mar 2020 16:49:06 +0100 Jiri Pirko wrote: >> This patchset includes couple of patches in reaction to the discussions >> to the original HW stats patchset. The first patch is a fix, >> the other two patches are basically cosmetics. > >Reviewed-by: Jakub Kicinski <kuba@...nel.org> > >This problem already exists, but writing a patch for nfp I noticed that >there is no way for this: > > if (!flow_action_hw_stats_types_check(flow_action, extack, > FLOW_ACTION_HW_STATS_TYPE_DELAYED_BIT)) > return -EOPNOTSUPP; > >to fit on a line for either bit, which kind of sucks. Yeah, I was thinking about having flow_action_hw_stats_types_check as a macro and then just simply have: if (!flow_action_hw_stats_types_check(flow_action, extack, DELAYED)) return -EOPNOTSUPP; WDYT? > >I may send a rename...
Powered by blists - more mailing lists