netdev - Re: [PATCH v2 bpf-next 2/3] bpftool: skeleton should depend on libbpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf7fdd9c-f43d-1ef5-dad3-961a4534463c@isovalent.com>
Date:   Thu, 12 Mar 2020 11:46:51 +0000
From:   Quentin Monnet <quentin@...valent.com>
To:     Song Liu <songliubraving@...com>, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Cc:     john.fastabend@...il.com, kernel-team@...com, ast@...nel.org,
        daniel@...earbox.net, arnaldo.melo@...il.com, jolsa@...nel.org
Subject: Re: [PATCH v2 bpf-next 2/3] bpftool: skeleton should depend on libbpf

2020-03-11 15:18 UTC-0700 ~ Song Liu <songliubraving@...com>
> Add the dependency to libbpf, to fix build errors like:
> 
>   In file included from skeleton/profiler.bpf.c:5:
>   .../bpf_helpers.h:5:10: fatal error: 'bpf_helper_defs.h' file not found
>   #include "bpf_helper_defs.h"
>            ^~~~~~~~~~~~~~~~~~~
>   1 error generated.
>   make: *** [skeleton/profiler.bpf.o] Error 1
>   make: *** Waiting for unfinished jobs....
> 
> Fixes: 47c09d6a9f67 ("bpftool: Introduce "prog profile" command")
> Acked-by: John Fastabend <john.fastabend@...il.com>
> Signed-off-by: Song Liu <songliubraving@...com>

Reviewed-by: Quentin Monnet <quentin@...valent.com>