netdev - Re: [PATCH net-next] Revert "net: sched: make newly activated qdiscs visible"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200312.111952.2245144514177634841.davem@davemloft.net>
Date:   Thu, 12 Mar 2020 11:19:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jwi@...ux.ibm.com
Cc:     netdev@...r.kernel.org, mkubecek@...e.cz, edumazet@...gle.com,
        jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [PATCH net-next] Revert "net: sched: make newly activated
 qdiscs visible"

From: Julian Wiedmann <jwi@...ux.ibm.com>
Date: Thu, 12 Mar 2020 18:57:54 +0100

> This reverts commit 4cda75275f9f89f9485b0ca4d6950c95258a9bce
> from net-next.
> 
> Brown bag time.
> 
> Michal noticed that this change doesn't work at all when
> netif_set_real_num_tx_queues() gets called prior to an initial
> dev_activate(), as for instance igb does.
> 
> Doing so dies with:
 ...
> Fixes: 4cda75275f9f ("net: sched: make newly activated qdiscs visible")
> Reported-by: Michal Kubecek <mkubecek@...e.cz>
> CC: Michal Kubecek <mkubecek@...e.cz>
> CC: Eric Dumazet <edumazet@...gle.com>
> CC: Jamal Hadi Salim <jhs@...atatu.com>
> CC: Cong Wang <xiyou.wangcong@...il.com>
> CC: Jiri Pirko <jiri@...nulli.us>
> Signed-off-by: Julian Wiedmann <jwi@...ux.ibm.com>

Applied, thanks for dealing with this so quickly.