netdev - Re: [PATCH net] net: fec: validate the new settings in fec_enet_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Mar 2020 22:42:13 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kuba@...nel.org
Cc:     netdev@...r.kernel.org, fugang.duan@....com, frank.li@....com
Subject: Re: [PATCH net] net: fec: validate the new settings in
 fec_enet_set_coalesce()

From: Jakub Kicinski <kuba@...nel.org>
Date: Tue, 10 Mar 2020 20:36:16 -0700

> fec_enet_set_coalesce() validates the previously set params
> and if they are within range proceeds to apply the new ones.
> The new ones, however, are not validated. This seems backwards,
> probably a copy-paste error?
> 
> Compile tested only.
> 
> Fixes: d851b47b22fc ("net: fec: add interrupt coalescence feature support")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Applied and queued up for -stable, thanks.