netdev - Re: [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough;

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62ed1e9972f5d7d8a203e9295c388a70e6e9e0c2.camel@perches.com>
Date:   Thu, 12 Mar 2020 12:52:30 -0700
From:   Joe Perches <joe@...ches.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>, borisp@...lanox.com,
        saeedm@...lanox.com, leon@...nel.org, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use
 fallthrough;

On Thu, 2020-03-12 at 12:45 -0700, Jakub Kicinski wrote:
> On Wed, 11 Mar 2020 23:26:59 -0700 Joe Perches wrote:
> > On Wed, 2020-03-11 at 23:23 -0700, David Miller wrote:
> > > Joe, please use Subject line subsystem prefixes consistent with what would
> > > be used for other changes to these drivers.  
> > 
> > Not easy to do for scripted patches.
> > There's no mechanism that scriptable.
> 
> I have this to show me the top 3 prefixes used for files currently
> modified in my tree:
> 
> tgs() {
>     local fs
> 
>     fs=$(git status -s | sed -n 's/ M //p')
> 
>     git log --oneline --no-merges -- $fs | \
> 	sed -e's/[^ ]* \(.*\):[^:]*/\1/' | \
> 	sort | uniq -c | sort -rn | head -3
> }
> 
> You could probably massage it to just give you to top one and feed 
> that into git commit template?

I had already tried that via:

$ cat get_patch_subject_prefix.bash 
#!/bin/bash
git log --format="%s" --no-merges -200 --since=2-years-ago $@ | \
  cut -f1 -d":" | \
  sort  | uniq -c | sort -rn | head -1 | \
  sed 's/^[[:space:]]*[[:digit:]]*[[:space:]]*//'
$ 

It doesn't work very well for many of the subsystems.

For instance, this script produces things like:

ARM/ZYNQ ARCHITECTURE: treewide
FCOE SUBSYSTEM (libfc, libfcoe, fcoe): scsi
WOLFSON MICROELECTRONICS DRIVERS: ASoC

There isn't a great single mechanism for this.

At various times, I have proposed adding a grammar for
patch subject titles to MAINTAINERS.

Like:
https://lore.kernel.org/lkml/1289919077.28741.50.camel@Joe-Laptop/