netdev - Re: [PATCH net] net: phy: fix MDIO bus PM PHY resuming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5fba21d7-afc4-3096-0c28-f449d287e50d@gmail.com>
Date:   Thu, 12 Mar 2020 14:33:40 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Heiner Kallweit <hkallweit1@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        David Miller <davem@...emloft.net>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net: phy: fix MDIO bus PM PHY resuming

On 3/12/20 2:25 PM, Heiner Kallweit wrote:
> So far we have the unfortunate situation that mdio_bus_phy_may_suspend()
> is called in suspend AND resume path, assuming that function result is
> the same. After the original change this is no longer the case,
> resulting in broken resume as reported by Geert.
> 
> To fix this call mdio_bus_phy_may_suspend() in the suspend path only,
> and let the phy_device store the info whether it was suspended by
> MDIO bus PM.
> 
> Fixes: 503ba7c69610 ("net: phy: Avoid multiple suspends")
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Tested-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Thanks both for continuing to work on this.
-- 
Florian