netdev - Re: [PATCH] net/bpfilter: fix dprintf usage for logging into /dev/kmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200312.153456.472585037753603767.davem@davemloft.net>
Date:   Thu, 12 Mar 2020 15:34:56 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     bmeneg@...hat.com
Cc:     linux-kernel@...r.kernel.org, bpf@...r.kernel.org,
        netdev@...r.kernel.org, GLin@...e.com, kuba@...nel.org,
        ast@...nel.org
Subject: Re: [PATCH] net/bpfilter: fix dprintf usage for logging into
 /dev/kmsg

From: Bruno Meneguele <bmeneg@...hat.com>
Date: Thu, 12 Mar 2020 17:12:40 -0300

> The bpfilter UMH code was recently changed to log its informative messages to
> /dev/kmsg, however this interface doesn't support SEEK_CUR yet, used by
> dprintf(). As result dprintf() returns -EINVAL and doesn't log anything.
> 
> Although there already had some discussions about supporting SEEK_CUR into
> /dev/kmsg in the past, it wasn't concluded. Considering the only
> user of that interface from userspace perspective inside the kernel is the
> bpfilter UMH (userspace) module it's better to correct it here instead of
> waiting a conclusion on the interface changes.
> 
> Signed-off-by: Bruno Meneguele <bmeneg@...hat.com>

Please repost this with a proper Fixes: tag.

Thank you.