netdev - Re: [PATCH net-next 1/7] ionic: tx and rx queues state follows link state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200312.154110.308373641367156886.davem@davemloft.net>
Date:   Thu, 12 Mar 2020 15:41:10 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     snelson@...sando.io
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/7] ionic: tx and rx queues state follows
 link state

From: Shannon Nelson <snelson@...sando.io>
Date: Thu, 12 Mar 2020 14:50:09 -0700

> +		if (!test_bit(IONIC_LIF_F_UP, lif->state) &&
> +		    netif_running(netdev)) {
> +			rtnl_lock();
> +			ionic_open(netdev);
> +			rtnl_unlock();
>  		}

You're running into a major problem area here.

ionic_open() can fail, particularly because it allocates resources.

Yet you are doing this in an operational path that doesn't handle
and unwind from errors.

You must find a way to do this properly, because the current approach
can result in an inoperable interface.