netdev - Re: [PATCH 2/8] raw: Add missing annotations to raw_seq_start() and raw_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200311.232008.336536129448429278.davem@davemloft.net>
Date:   Wed, 11 Mar 2020 23:20:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jbi.octave@...il.com
Cc:     boqun.feng@...il.com, linux-kernel@...r.kernel.org,
        bpf@...r.kernel.org, netdev@...r.kernel.org, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org, kuba@...nel.org
Subject: Re: [PATCH 2/8] raw: Add missing annotations to raw_seq_start()
 and raw_seq_stop()

From: Jules Irenge <jbi.octave@...il.com>
Date: Wed, 11 Mar 2020 01:09:02 +0000

> Sparse reports warnings at raw_seq_start() and raw_seq_stop()
> 
> warning: context imbalance in raw_seq_start() - wrong count at exit
> warning: context imbalance in raw_seq_stop() - unexpected unlock
> 
> The root cause is the missing annotations at raw_seq_start()
> 	and raw_seq_stop()
> Add the missing __acquires(&h->lock) annotation
> Add the missing __releases(&h->lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@...il.com>

Applied.