netdev - Re: [PATCH net] net: memcg: fix lockdep splat in inet_csk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200311.235823.220996291757645509.davem@davemloft.net>
Date:   Wed, 11 Mar 2020 23:58:23 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        shakeelb@...gle.com, syzkaller@...glegroups.com
Subject: Re: [PATCH net] net: memcg: fix lockdep splat in inet_csk_accept()

From: Eric Dumazet <edumazet@...gle.com>
Date: Wed, 11 Mar 2020 11:44:26 -0700

> Locking newsk while still holding the listener lock triggered
> a lockdep splat [1]
> 
> We can simply move the memcg code after we release the listener lock,
> as this can also help if multiple threads are sharing a common listener.
> 
> Also fix a typo while reading socket sk_rmem_alloc.
 ...
> Fixes: d752a4986532 ("net: memcg: late association of sock to memcg")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Shakeel Butt <shakeelb@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied, thanks Eric.