netdev - Re: [PATCH net-next 04/15] net: mvpp2: reject unsupported coalescing params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Mar 2020 12:05:55 +0100
From:   Matteo Croce <mcroce@...hat.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>, kernel-team@...com,
        cooldavid@...ldavid.org, sebastian.hesselbarth@...il.com,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>,
        Russell King <rmk+kernel@...linux.org.uk>,
        sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com,
        hkelam@...vell.com, mlindner@...vell.com,
        Stephen Hemminger <stephen@...workplumber.org>,
        christopher.lee@...i.com, manishc@...vell.com, rahulv@...vell.com,
        GR-Linux-NIC-Dev@...vell.com, aelior@...vell.com,
        GR-everest-linux-l2@...vell.com, shshaikh@...vell.com,
        nic_swsd@...ltek.com, hkallweit1@...il.com, bh74.an@...sung.com,
        romieu@...zoreil.com
Subject: Re: [PATCH net-next 04/15] net: mvpp2: reject unsupported coalescing params

On Fri, Mar 13, 2020 at 5:08 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Set ethtool_ops->supported_coalesce_params to let
> the core reject unsupported coalescing parameters.
>
> This driver did not previously reject unsupported parameters.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> index 6b9c7ed2547e..1fa60e985b43 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> @@ -4384,6 +4384,8 @@ static const struct net_device_ops mvpp2_netdev_ops = {
>  };
>
>  static const struct ethtool_ops mvpp2_eth_tool_ops = {
> +       .supported_coalesce_params = ETHTOOL_COALESCE_USECS |
> +                                    ETHTOOL_COALESCE_MAX_FRAMES,
>         .nway_reset             = mvpp2_ethtool_nway_reset,
>         .get_link               = ethtool_op_get_link,
>         .set_coalesce           = mvpp2_ethtool_set_coalesce,
> --
> 2.24.1
>

Acked-by: Matteo Croce <mcroce@...hat.com>

-- 
Matteo Croce
per aspera ad upstream