netdev - RE: [PATCH v2] net: Make skb_segment not to compute checksum if network controller supports checksumming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c1768ab119241168ecac9879b24d022@AcuMS.aculab.com>
Date:   Fri, 13 Mar 2020 14:04:32 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Willem de Bruijn' <willemdebruijn.kernel@...il.com>,
        Yadu Kishore <kyk.segfault@...il.com>
CC:     David Miller <davem@...emloft.net>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Network Development <netdev@...r.kernel.org>
Subject: RE: [PATCH v2] net: Make skb_segment not to compute checksum if
 network controller supports checksumming

> On Fri, Mar 13, 2020 at 2:36 AM Yadu Kishore <kyk.segfault@...il.com> wrote:
> >
> > > Yes, given the discussion I have no objections. The change to
> > > skb_segment in v2 look fine.
> >
> > I'm assuming that the changes in patch V2 are ok to be accepted and merged
> > to the kernel. Please let me know if there is anything else that is pending
> > from my side with respect to the patch.
> 
> I think you can rebase and submit against net-next.

It's also worth mentioning (probably in 0/n) that
this is likely to be a gain even on x86 where the
checksum is calculated during the copy loop.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)