netdev - Re: [PATCH net-next v2 1/2] mptcp: create msk early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b85c12a-ddae-a8f6-e4ec-047b0fc6f28b@tessares.net>
Date:   Fri, 13 Mar 2020 17:08:30 +0100
From:   Matthieu Baerts <matthieu.baerts@...sares.net>
To:     Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Mat Martineau <mathew.j.martineau@...ux.intel.com>
Subject: Re: [PATCH net-next v2 1/2] mptcp: create msk early

On 13/03/2020 16:52, Paolo Abeni wrote:
> This change moves the mptcp socket allocation from mptcp_accept() to
> subflow_syn_recv_sock(), so that subflow->conn is now always set
> for the non fallback scenario.
> 
> It allows cleaning up a bit mptcp_accept() reducing the additional
> locking and will allow fourther cleanup in the next patch.
> 
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

LGTM, Thanks Paolo!

Reviewed-by: Matthieu Baerts <matthieu.baerts@...sares.net>