[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CADVnQymxAXO038MONZKTR3HxaVNANRL_BtQzhgUXefr5zr1czQ@mail.gmail.com>
Date: Fri, 13 Mar 2020 14:21:03 -0400
From: Neal Cardwell <ncardwell@...gle.com>
To: Pengcheng Yang <yangpc@...gsu.com>
Cc: Eric Dumazet <edumazet@...gle.com>,
David Miller <davem@...emloft.net>,
Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/5] tcp: fix stretch ACK bugs in BIC
On Fri, Mar 13, 2020 at 12:48 PM Pengcheng Yang <yangpc@...gsu.com> wrote:
>
> Neal Cardwell submits a series of patches to handle stretched ACKs,
> which start with commit e73ebb0881ea ("tcp: stretch ACK fixes prep").
>
> This patch changes BIC to properly handle stretch ACKs in additive
> increase mode by passing in the count of ACKed packets to
> tcp_cong_avoid_ai().
>
> Signed-off-by: Pengcheng Yang <yangpc@...gsu.com>
> ---
> net/ipv4/tcp_bic.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/net/ipv4/tcp_bic.c b/net/ipv4/tcp_bic.c
> index 645cc30..f5f588b 100644
> --- a/net/ipv4/tcp_bic.c
> +++ b/net/ipv4/tcp_bic.c
> @@ -145,12 +145,13 @@ static void bictcp_cong_avoid(struct sock *sk, u32 ack, u32 acked)
> if (!tcp_is_cwnd_limited(sk))
> return;
>
> - if (tcp_in_slow_start(tp))
> - tcp_slow_start(tp, acked);
> - else {
> - bictcp_update(ca, tp->snd_cwnd);
> - tcp_cong_avoid_ai(tp, ca->cnt, 1);
> + if (tcp_in_slow_start(tp)) {
> + acked = tcp_slow_start(tp, acked);
> + if (!acked)
> + return;
> }
> + bictcp_update(ca, tp->snd_cwnd);
> + tcp_cong_avoid_ai(tp, ca->cnt, acked);
> }
>
> /*
> --
Acked-by: Neal Cardwell <ncardwell@...gle.com>
thanks,
neal
Powered by blists - more mailing lists