netdev - Re: [net-next 07/14] net/mlx5: E-Switch, Update VF vports config when num of VFs changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82a53bad75c33302461a19953b962ca22089d7e2.camel@mellanox.com>
Date:   Sat, 14 Mar 2020 06:13:43 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "kuba@...nel.org" <kuba@...nel.org>
CC:     Parav Pandit <parav@...lanox.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Bodong Wang <bodong@...lanox.com>
Subject: Re: [net-next 07/14] net/mlx5: E-Switch, Update VF vports config when
 num of VFs changed

On Fri, 2020-03-13 at 19:36 -0700, Jakub Kicinski wrote:
> On Fri, 13 Mar 2020 18:16:15 -0700 Saeed Mahameed wrote:
> > From: Bodong Wang <bodong@...lanox.com>
> > 
> > Currently, ECPF eswitch manager does one-time only configuration
> > for
> > VF vports when device switches to offloads mode. However, when num
> > of
> > VFs changed from host side, driver doesn't update VF vports
> > configurations.
> > 
> > Hence, perform VFs vport configuration update whenever num_vfs
> > change
> > event occurs.
> 
> Oh, I thought you kept max_vfs number of reprs on the ECPF, always.
> Or was that just the initial plan?

No, Smartnic's ECPF switchdev was required to be loaded only after host
PF enables sriov, so it will get the correct num_vfs and initialize
eswitch and reps accordingly.

3 reasons to change this:
1. Remove the dependency of when to load the switchdev mode in ECPF and
make the admin life easier
2. better code dynamics and vport management.
3. pave the way for future support of dynamically created Sub-
functions..