netdev - Re: [PATCH net-next 5/8] net: dsa: mv88e6xxx: fix Serdes link changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200314184848.GI5388@lunn.ch>
Date:   Sat, 14 Mar 2020 19:48:48 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH net-next 5/8] net: dsa: mv88e6xxx: fix Serdes link changes

On Sat, Mar 14, 2020 at 10:15:48AM +0000, Russell King wrote:
> phylink_mac_change() is supposed to be called with a 'false' argument
> if the link has gone down since it was last reported up; this is to
> ensure that link events along with renegotiation events are always
> correctly reported to userspace.
> 
> Read the BMSR once when we have an interrupt, and report the link
> latched status to phylink via phylink_mac_change().  phylink will deal
> automatically with re-reading the link state once it has processed the
> link-down event.
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew