netdev - Re: [PATCH net-next 6/8] net: dsa: mv88e6xxx: combine port_set_speed and port_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200314184908.GJ5388@lunn.ch>
Date:   Sat, 14 Mar 2020 19:49:08 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH net-next 6/8] net: dsa: mv88e6xxx: combine port_set_speed
 and port_set_duplex

On Sat, Mar 14, 2020 at 10:15:53AM +0000, Russell King wrote:
> Setting the speed independently of duplex makes little sense; the two
> parameters result from negotiation or fixed setup, and may have inter-
> dependencies. Moreover, they are always controlled via the same
> register - having them split means we have to read-modify-write this
> register twice.
> 
> Combine the two operations into a single port_set_speed_duplex()
> operation. Not only is this more efficient, it reduces the size of the
> code as well.
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew