netdev - Re: [PATCH -next] net/mlx5: Add missing inline to stub esw_add_restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 16 Mar 2020 21:17:00 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "natechancellor@...il.com" <natechancellor@...il.com>,
        Paul Blakey <paulb@...lanox.com>
CC:     Oz Shlomo <ozsh@...lanox.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Vlad Buslov <vladbu@...lanox.com>,
        "clang-built-linux@...glegroups.com" 
        <clang-built-linux@...glegroups.com>,
        Jiri Pirko <jiri@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "jakub.kicinski@...ronome.com" <jakub.kicinski@...ronome.com>,
        Roi Dayan <roid@...lanox.com>
Subject: Re: [PATCH -next] net/mlx5: Add missing inline to stub
 esw_add_restore_rule

On Fri, 2020-03-13 at 20:40 -0700, Nathan Chancellor wrote:
> When CONFIG_MLX5_ESWITCH is unset, clang warns:
> 
> In file included from
> drivers/net/ethernet/mellanox/mlx5/core/main.c:58:
> drivers/net/ethernet/mellanox/mlx5/core/eswitch.h:670:1: warning:
> unused
> function 'esw_add_restore_rule' [-Wunused-function]
> esw_add_restore_rule(struct mlx5_eswitch *esw, u32 tag)
> ^
> 1 warning generated.
> 
> This stub function is missing inline; add it to suppress the warning.
> 
> Fixes: 11b717d61526 ("net/mlx5: E-Switch, Get reg_c0 value on CQE")
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
> b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
> index 2e0417dd8ce3..470a16e63242 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
> @@ -666,7 +666,7 @@ static inline const u32
> *mlx5_esw_query_functions(struct mlx5_core_dev *dev)
>  
>  static inline void mlx5_eswitch_update_num_of_vfs(struct
> mlx5_eswitch *esw, const int num_vfs) {}
>  
> -static struct mlx5_flow_handle *
> +static inline struct mlx5_flow_handle *
>  esw_add_restore_rule(struct mlx5_eswitch *esw, u32 tag)
>  {
>  	return ERR_PTR(-EOPNOTSUPP);

Applied to net-next-mlx5 

Thanks,
Saeed.