netdev - Re: [PATCH V1 net 4/7] net: ena: remove code that does nothing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200316145615.238af848@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 16 Mar 2020 14:56:15 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     <akiyano@...zon.com>
Cc:     <davem@...emloft.net>, <netdev@...r.kernel.org>, <dwmw@...zon.com>,
        <zorik@...zon.com>, <matua@...zon.com>, <saeedb@...zon.com>,
        <msw@...zon.com>, <aliguori@...zon.com>, <nafea@...zon.com>,
        <gtzalik@...zon.com>, <netanel@...zon.com>, <alisaidi@...zon.com>,
        <benh@...zon.com>, <ndagan@...zon.com>, <shayagr@...zon.com>,
        <sameehj@...zon.com>
Subject: Re: [PATCH V1 net 4/7] net: ena: remove code that does nothing

On Mon, 16 Mar 2020 14:38:21 +0200 akiyano@...zon.com wrote:
> From: Arthur Kiyanovski <akiyano@...zon.com>
> 
> Both key and func parameters are pointers on the stack.
> Setting them to NULL does nothing.
> The original intent was to leave the key and func unset in this case,
> but for this to happen nothing needs to be done as the calling
> function ethtool_get_rxfh() already clears key and func.
> 
> This commit removes the above described useless code.
> 
> Fixes: 0c8923c0a64f ("net: ena: rss: fix failure to get indirection table")
> Signed-off-by: Sameeh Jubran <sameehj@...zon.com>
> Signed-off-by: Arthur Kiyanovski <akiyano@...zon.com>

Why is this a fix?