lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 16 Mar 2020 15:01:36 -0700 (PDT)
From:   David Miller <>
Subject: Re: [PATCH net-next] qede: remove some unused code in function

From: Zheng Zengkai <>
Date: Mon, 16 Mar 2020 21:05:24 +0800

> Remove set but not used variables 'sw_comp_cons' and 'hw_comp_cons'
> to fix gcc '-Wunused-but-set-variable' warning:
> drivers/net/ethernet/qlogic/qede/qede_ethtool.c: In function qede_selftest_receive_traffic:
> drivers/net/ethernet/qlogic/qede/qede_ethtool.c:1569:20:
>  warning: variable sw_comp_cons set but not used [-Wunused-but-set-variable]
> drivers/net/ethernet/qlogic/qede/qede_ethtool.c: In function qede_selftest_receive_traffic:
> drivers/net/ethernet/qlogic/qede/qede_ethtool.c:1569:6:
>  warning: variable hw_comp_cons set but not used [-Wunused-but-set-variable]
> After removing 'hw_comp_cons',the memory barrier 'rmb()' and its comments become useless,
> so remove them as well.
> Reported-by: Hulk Robot <>
> Signed-off-by: Zheng Zengkai <>

Applied, thank you.

Powered by blists - more mailing lists