netdev - Re: [PATCH net-next 3/3] net_sched: sch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Mar 2020 16:16:35 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Willem de Bruijn <willemb@...gle.com>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net-next 3/3] net_sched: sch_fq: enable use of hrtimer
 slack

On Mon, 16 Mar 2020 16:02:23 -0700 Eric Dumazet wrote:
> @@ -747,6 +750,7 @@ static const struct nla_policy fq_policy[TCA_FQ_MAX + 1] = {

nit: since nothing has been added to fq_policy since we introduced
     strict netlink checking please consider adding:

	[TCA_FQ_UNSPEC] = { .strict_start_type = TCA_FQ_TIMER_SLACK },

>  	[TCA_FQ_ORPHAN_MASK]		= { .type = NLA_U32 },
>  	[TCA_FQ_LOW_RATE_THRESHOLD]	= { .type = NLA_U32 },
>  	[TCA_FQ_CE_THRESHOLD]		= { .type = NLA_U32 },
> +	[TCA_FQ_TIMER_SLACK]		= { .type = NLA_U32 },