netdev - RE: [PATCH net 1/3] net: fsl/fman: treat all RGMII modes in memac_adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB8PR04MB69859D7B209FEA972409FEEBECF90@DB8PR04MB6985.eurprd04.prod.outlook.com>
Date:   Mon, 16 Mar 2020 07:49:29 +0000
From:   "Madalin Bucur (OSS)" <madalin.bucur@....nxp.com>
To:     Andrew Lunn <andrew@...n.ch>,
        "Madalin Bucur (OSS)" <madalin.bucur@....nxp.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        Leo Li <leoyang.li@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net 1/3] net: fsl/fman: treat all RGMII modes in
 memac_adjust_link()

> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Saturday, March 14, 2020 11:16 PM
> To: Madalin Bucur (OSS) <madalin.bucur@....nxp.com>
> Cc: davem@...emloft.net; netdev@...r.kernel.org;
> devicetree@...r.kernel.org; shawnguo@...nel.org; Leo Li
> <leoyang.li@....com>; robh+dt@...nel.org; mark.rutland@....com; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH net 1/3] net: fsl/fman: treat all RGMII modes in
> memac_adjust_link()
> 
> On Fri, Mar 13, 2020 at 02:04:23PM +0200, Madalin Bucur wrote:
> > Treat all internal delay variants the same as RGMII.
> >
> > Signed-off-by: Madalin Bucur <madalin.bucur@....nxp.com>
> > ---
> >  drivers/net/ethernet/freescale/fman/fman_memac.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c
> b/drivers/net/ethernet/freescale/fman/fman_memac.c
> > index e1901874c19f..0fc98584974a 100644
> > --- a/drivers/net/ethernet/freescale/fman/fman_memac.c
> > +++ b/drivers/net/ethernet/freescale/fman/fman_memac.c
> > @@ -782,7 +782,10 @@ int memac_adjust_link(struct fman_mac *memac, u16
> speed)
> >  	/* Set full duplex */
> >  	tmp &= ~IF_MODE_HD;
> >
> > -	if (memac->phy_if == PHY_INTERFACE_MODE_RGMII) {
> > +	if (memac->phy_if == PHY_INTERFACE_MODE_RGMII ||
> > +	    memac->phy_if == PHY_INTERFACE_MODE_RGMII_ID ||
> > +	    memac->phy_if == PHY_INTERFACE_MODE_RGMII_RXID ||
> > +	    memac->phy_if == PHY_INTERFACE_MODE_RGMII_TXID) {
> 
> Hi Madalin
> 
> You can use phy_interface_mode_is_rgmii()
> 
>     Andrew

I have that on the todo list for all the places in the code, but that's
net-next material.

Thanks,
Madalin