netdev - Re: [Patch net] net_sched: cls_route: remove the right filter from hashtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200316.020100.467958998097459111.davem@davemloft.net>
Date:   Mon, 16 Mar 2020 02:01:00 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org,
        syzbot+f9b32aaacd60305d9687@...kaller.appspotmail.com,
        syzbot+2f8c233f131943d6056d@...kaller.appspotmail.com,
        syzbot+9c2df9fd5e9445b74e01@...kaller.appspotmail.com,
        jhs@...atatu.com, jiri@...nulli.us, john.fastabend@...il.com
Subject: Re: [Patch net] net_sched: cls_route: remove the right filter from
 hashtable

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Fri, 13 Mar 2020 22:29:54 -0700

> route4_change() allocates a new filter and copies values from
> the old one. After the new filter is inserted into the hash
> table, the old filter should be removed and freed, as the final
> step of the update.
> 
> However, the current code mistakenly removes the new one. This
> looks apparently wrong to me, and it causes double "free" and
> use-after-free too, as reported by syzbot.
> 
> Reported-and-tested-by: syzbot+f9b32aaacd60305d9687@...kaller.appspotmail.com
> Reported-and-tested-by: syzbot+2f8c233f131943d6056d@...kaller.appspotmail.com
> Reported-and-tested-by: syzbot+9c2df9fd5e9445b74e01@...kaller.appspotmail.com
> Fixes: 1109c00547fc ("net: sched: RCU cls_route")
> Cc: Jamal Hadi Salim <jhs@...atatu.com>
> Cc: Jiri Pirko <jiri@...nulli.us>
> Cc: John Fastabend <john.fastabend@...il.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied and queued up for -stable, thanks Cong.