lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 16 Mar 2020 09:32:25 +0000
From:   Chris Packham <>
To:     "" <>
CC:     "" <>,
        "" <>,
        "" <>,
        "" <>
Subject: Re: [PATCH v2] net: mvmdio: avoid error message for optional IRQ

On Mon, 2020-03-16 at 09:38 +0100, Andrew Lunn wrote:
> > Actually on closer inspection I think this is wrong.
> > platform_get_irq_optional() will return -ENXIO if the irq is not
> > specified.
> The _optional is then pointless. And different to all the other
> _optional functions which don't return an error if the property is
> not
> defined.
> Are you really sure about this? I don't have the time right now to
> check.

Regretabbly yes[1]. It caught me by surprise too. I only noticed when I
went to use a different board that used that driver. I think the
problem is that on some platforms 0 is a valid irq so it can't just be
used to indicate a missing interrupt.

[1] -

Powered by blists - more mailing lists