netdev - Re: [PATCH net 3/3] ethtool: reject unrecognized request flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <09ec9c9b-10d3-510b-df0d-bf9f06bf99da@cogentembedded.com>
Date:   Mon, 16 Mar 2020 12:39:44 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Michal Kubecek <mkubecek@...e.cz>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Cc:     Johannes Berg <johannes@...solutions.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 3/3] ethtool: reject unrecognized request flags

Hello!

On 15.03.2020 20:17, Michal Kubecek wrote:

> As pointed out by Jakub Kicinski, we ethtool netlink code should respond

    s/we/the/?

> with an error if request head has flags set which are not recognized by
> kernel, either as a mistake or because it expects functionality introduced
> in later kernel versions.
> 
> To avoid unnecessary roundtrips, use extack cookie to  provide the
> information about supported request flags.
> 
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>
[...]

MBR, Sergei