netdev - Re: [PATCH bpf-next 0/4] bpftool: Add struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5db1351a-f197-f792-04ef-231811edef53@isovalent.com>
Date:   Mon, 16 Mar 2020 11:54:41 +0000
From:   Quentin Monnet <quentin@...valent.com>
To:     Martin KaFai Lau <kafai@...com>, bpf@...r.kernel.org
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, kernel-team@...com,
        netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next 0/4] bpftool: Add struct_ops support

2020-03-15 17:55 UTC-0700 ~ Martin KaFai Lau <kafai@...com>
> This set adds "struct_ops" support to bpftool.
> 
> The first two patches improve the btf_dumper in bpftool.
> Patch 1: print the enum's name (if it is found) instead of the
>          enum's value.
> Patch 2: print a char[] as a string if all characters are printable.
> 
> "struct_ops" stores the prog_id in a func ptr.
> Instead of printing a prog_id,
> patch 3 adds an option to btf_dumper to allow a func ptr's value
> to be printed with the full func_proto info and the prog_name.
> 
> Patch 4 implements the "struct_ops" bpftool command.

Hi Martin, I have a few very small nits on patch 4 -- please see related
message -- but other than this your series looks good to me.

Acked-by: Quentin Monnet <quentin@...valent.com>

(I did not test it, though.)

Thanks,
Quentin