netdev - RE: [PATCH] net: vxge: fix wrong __VA_ARGS_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e61d7621d4ac4b909fda59f234d587fa@AcuMS.aculab.com>
Date:   Tue, 17 Mar 2020 10:10:53 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'David Miller' <davem@...emloft.net>,
        "wei.zheng@...o.com" <wei.zheng@...o.com>
CC:     "catalin.marinas@....com" <catalin.marinas@....com>,
        "will@...nel.org" <will@...nel.org>,
        "jdmason@...zu.us" <jdmason@...zu.us>,
        "yeyunfeng@...wei.com" <yeyunfeng@...wei.com>,
        "guohanjun@...wei.com" <guohanjun@...wei.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "info@...ux.net" <info@...ux.net>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kernel@...o.com" <kernel@...o.com>,
        "wenhu.wang@...o.com" <wenhu.wang@...o.com>
Subject: RE: [PATCH] net: vxge: fix wrong __VA_ARGS__ usage

> > printk in macro vxge_debug_ll uses __VA_ARGS__ without "##" prefix,
> > it causes a build error when there is no variable
> > arguments(e.g. only fmt is specified.).
> >
> > Signed-off-by: Zheng Wei <wei.zheng@...o.com>
> 
> Does this even happen right now?  Anyways, applied.

I thought most of the compilers removed the lurking ','
using some heristic.

A safer alternative is to include the 'fmt' in the ...
then there is always one argument.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)