netdev - Re: [PATCH v3 1/2] Revert "net: mvmdio: avoid error message for optional IRQ"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200317142515.GV24270@lunn.ch>
Date:   Tue, 17 Mar 2020 15:25:15 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc:     davem@...emloft.net, josua@...id-run.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] Revert "net: mvmdio: avoid error message for
 optional IRQ"

On Mon, Mar 16, 2020 at 08:49:06PM +1300, Chris Packham wrote:
> This reverts commit e1f550dc44a4d535da4e25ada1b0eaf8f3417929.
> platform_get_irq_optional() will still return -ENXIO when no interrupt
> is provided so the additional error handling caused the driver prone to
> fail when no interrupt was specified. Revert the change so we can apply
> the correct minimal fix.
> 
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew