netdev - Re: [PATCH net-next 09/11] devlink: Add new enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200317105220.3ae07cad@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 17 Mar 2020 10:52:20 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vasundhara Volam <vasundhara-v.volam@...adcom.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        Pavan Chebbi <pavan.chebbi@...adcom.com>,
        Jiri Pirko <jiri@...lanox.com>,
        Michael Chan <michael.chan@...adcom.com>
Subject: Re: [PATCH net-next 09/11] devlink: Add new enable_ecn generic
 device param

On Tue, 17 Mar 2020 20:47:24 +0530 Vasundhara Volam wrote:
> From: Pavan Chebbi <pavan.chebbi@...adcom.com>
> 
> Add new device parameter to enable/disable handling of Explicit
> Congestion Notification(ECN) in the device.
> 
> This patch also addresses comments from Jiri Pirko, to update the
> devlink-info.rst documentation.
> 
> Cc: Jiri Pirko <jiri@...lanox.com>
> Signed-off-by: Pavan Chebbi <pavan.chebbi@...adcom.com>
> Signed-off-by: Vasundhara Volam <vasundhara-v.volam@...adcom.com>
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>

Nacked-by: Jakub Kicinski <kuba@...nel.org>

We've been over this multiple times. Devlink is not for configuring
forwarding features. Use qdisc offload.