lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 18 Mar 2020 00:44:50 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Nick Desaulniers <ndesaulniers@...gle.com>,
        Stanislav Fomichev <sdf@...gle.com>
Cc:     Fangrui Song <maskray@...gle.com>,
        Stanislav Fomichev <sdf@...ichev.me>,
        bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Nathan Chancellor <natechancellor@...il.com>,
        clang-built-linux <clang-built-linux@...glegroups.com>,
        "David S. Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH bpf-next v5] bpf: Support llvm-objcopy and llvm-objdump
 for vmlinux BTF

On 3/18/20 12:14 AM, Nick Desaulniers wrote:
> On Tue, Mar 17, 2020 at 3:13 PM Stanislav Fomichev <sdf@...gle.com> wrote:
>> On Tue, Mar 17, 2020 at 3:08 PM Nick Desaulniers
>> <ndesaulniers@...gle.com> wrote:
>>> On Tue, Mar 17, 2020 at 3:01 PM Fangrui Song <maskray@...gle.com> wrote:
>>>> On 2020-03-17, Stanislav Fomichev wrote:
>>>>> Please keep small changelog here, for example:
>>>>>
>>>>> v5:
>>>>> * rebased on top of bpfnext
>>>>
>>>> Thanks for the tip. Add them at the bottom?
>>>
>>> "Below the fold" see this patch I just sent out:
>>> https://lore.kernel.org/lkml/20200317215515.226917-1-ndesaulniers@google.com/T/#u
>>> grep "Changes"
>>>
>>> $ git format-patch -v2 HEAD~
>>> $ vim 0001-...patch
>>> <manually add changelog "below the fold">
>> BPF subtree prefers the changelog in the commit body, not the comments
>> (iow, before ---).
>> Add them at the end of you message, see, for example:
>> https://lore.kernel.org/bpf/a428fb88-9b53-27dd-a195-497755944921@iogearbox.net/T/
> 
> Sigh, every maintainer is a special snowflake.  In our tree, you're
> only allowed to commit on Thursdays under a blood moon. /s
> 
> But thanks for the note.

For every commit into bpf/bpf-next we automatically put a 'Link:' tag pointing
to the lore.kernel.org/bpf long-term archive, so there is always an easy way to
retrieve additional information or discussions ([0] as one example). So whether
you put it above or below the '---' line I personally don't mind either way. All
crucial information that helps a reader later on to understand /why/ we ended up
exactly with the current change should be part of the main commit log though.

  [0] https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=483d7a30f538e2f8addd32aa9a3d2e94ae55fa65

Powered by blists - more mailing lists